Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 1 / Safari 5.1 add alignment-baseline CSS property #25442

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for Chrome and Safari for the alignment-baseline CSS property. The data comes from the mdn-bcd-collector project (v10.12.8).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/alignment-baseline

This PR updates and corrects version values for Chrome and Safari for the `alignment-baseline` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.12.8).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/alignment-baseline
@queengooborg queengooborg added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Dec 17, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Dec 17, 2024
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
@@ -98,7 +98,7 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "≤13.1"
"version_added": "≤5.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the default value seems to have changed from auto to baseline in Safari 18.1.

css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
css/properties/alignment-baseline.json Outdated Show resolved Hide resolved
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@@ -27,7 +27,7 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "≤13.1"
"version_added": "≤4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this test in Safari 5.0, and it doesn't appear to be supported yet:
image

However, it is supported in Safari 5.1:
image

So we can probably set all to "5.1".

@caugner caugner changed the title Update Chrome/Safari data for alignment-baseline CSS property Chrome 1 / Safari 5.1 add alignment-baseline CSS property Dec 20, 2024
@caugner caugner enabled auto-merge (squash) December 20, 2024 11:39
@caugner caugner merged commit e37b474 into mdn:main Dec 20, 2024
9 checks passed
@queengooborg queengooborg deleted the css/properties/alignment-baseline/webkit-corrections branch December 20, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants